Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkRd notes #599

Merged

Conversation

milanmlft
Copy link
Contributor

@milanmlft milanmlft commented Aug 5, 2024

R CMD check is showing a bunch of warnings that look like this:

N  checking Rd files ...
   checkRd: (-1) build_episode_md.Rd:32: Lost braces; missing escapes or markup?
       32 | {knitr} output.}
          | 

See for example https://github.com/carpentries/sandpaper/actions/runs/10153800168/job/28077829634#step:12:304
This should fix that.

I also updated some outdated docs, by running devtools::document()

@ErinBecker
Copy link
Contributor

Thanks @milanmlft! This looks great. The checks are failing due to a problem that @froggleston has fixed with #600, which has now been merged. Could you please pull down the changes to main into your fork, which will retrigger the tests? They should pass and then we can merge this.

@froggleston froggleston merged commit e645aac into carpentries:main Oct 8, 2024
11 checks passed
@milanmlft milanmlft deleted the milanmlft/fix-checkRd-notes branch October 9, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants