Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11/nest topics #31

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pelonchasva
Copy link

These changes fixes item #11 , it implementes a reducer in order to compare the data and create a new set of objects that represent the grouped items.

@carolinaknoll
Copy link
Owner

Hello, @pelonchasva!

Thank you for your contribution! Also, sorry for replying this late.

I have been reviewing your code and testing it on the project, and while the code is okay, there seems to be a small problem where if you click a topic children element, it will think the father was clicked and render the father's list instead.

For an example, when you open "Front-end Development", and then select "CSS - Critical Path Tools", which is now a child of the CSS topic, it will open the parent page instead.

I have been testing and trying a few solutions on this between all of the end-of-year activities, and will merge your PR as soon as I find a solution for this that is good enough. 😄

Thank you once again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants