Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT adding system tray icon #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

FEAT adding system tray icon #14

wants to merge 2 commits into from

Conversation

TheRedPhoenix
Copy link
Collaborator

Added temporary png to serve as Tray icon and Application Icon
Added dependency to QWidget (in certain Window Managers, if no default System Tray Icon is available, the framework will default to QWidget to deploy the feature)
Changed QGuiApplication to QApplication. Due to the potential dependency from QWidget, QApplication has to be used

@TheRedPhoenix
FEAT adding system tray icon
cbaf6ee 
> Added temporary png to serve as Tray icon and Application Icon
> Added dependency to QWidget (in certain Window Managers, if no default System Tray Icon is available, the framework will default to QWidget to deploy the feature)
> Changed QGuiApplication to QApplication. Due to the potential dependency from QWidget, QApplication has to be used
@TheRedPhoenix TheRedPhoenix linked an issue Jun 5, 2023 that may be closed by this pull request
FEAT Add support for system tray #7
Open
@TheRedPhoenix TheRedPhoenix requested a review from carminez88 June 5, 2023 14:31
carminez88
carminez88 reviewed Jun 5, 2023
View reviewed changes
Copy link
Owner

@carminez88 carminez88 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are almost trivial, no need for further comments.
Can be merged.
Before merging, conflicts must be resolved.

@carminez88
Copy link
Owner

Conflicts solved @ 1d3967f

@carminez88
Copy link
Owner

carminez88 commented Jun 5, 2023 •
edited
Loading

@TheRedPhoenix there is something strange on the system tray behaviour.

I have:

  • started the Visualization-Client
  • "closed" the software
    • at this point I would expect that it does not close but it just stays open on the system tray. This happens only for few seconds. Then the application closes.

I wouldn't have expected the actual closing. Is it something related to the Qt version?

I was testing on Win10, Qt 6.5.1, MSVC 2022

@carminez88 carminez88 mentioned this pull request Jun 5, 2023
Open
@TheRedPhoenix
Copy link
Collaborator Author

@TheRedPhoenix there is something strange on the system tray behaviour.

I have:

  • started the Visualization-Client

  • "closed" the software

    • at this point I would expect that it does not close but it just stays open on the system tray. This happens only for few seconds. Then the application closes.

I wouldn't have expected the actual closing. Is it something related to the Qt version?

I was testing on Win10, Qt 6.5.1, MSVC 2022

Mmhm what you are seing is the implemented behavior. I only added an icon to the system tray that allows to restore the window when minimized or restore focus to the window. I didn't overload the quit behavior, but we can do that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carminez88 carminez88 carminez88 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEAT Add support for system tray
2 participants
@TheRedPhoenix @carminez88