fixed raise and added tests

scrapli/helper.py

@@ -113,7 +113,7 @@ def textfsm_parse(
         output: structured data
 
     Raises:
-        N/A
+        textfsm.parser.TextFSMError: If raise_err is set and a textfsm parsing error occours
 
     """
     import textfsm  # pylint: disable=C0415
@@ -137,10 +137,10 @@ def textfsm_parse(
                 structured_output=structured_output, header=re_table.header
             )
         return structured_output
-    except textfsm.parser.TextFSMError as e:
+    except textfsm.parser.TextFSMError:
         logger.warning("failed to parse data with textfsm")
         if raise_err:
-            raise e
+            raise
     return []
 
 

tests/unit/test_helper.py

@@ -142,6 +142,13 @@ def test_textfsm_parse_failed_to_parse():
     assert result == []
 
 
+def test_textfsm_parse_failed_to_parse_with_raise():
+    template = _textfsm_get_template("cisco_ios", "show ip arp")
+    with pytest.raises(Exception):
+        result = textfsm_parse(template, "not really arp data", raise_err=True)
+        assert result == []
+
+
 @pytest.mark.skipif(
     sys.version_info.minor > 10, reason="genie not currently available for python 3.11"
 )

tests/unit/test_response.py

@@ -155,6 +155,14 @@ def test_response_parse_textfsm_fail():
     assert response.textfsm_parse_output() == []
 
 
+def test_response_parse_textfsm_fail_with_raise():
+    response = Response("localhost", channel_input="show ip arp", textfsm_platform="cisco_ios")
+    response_bytes = b"not ip arp output"
+    response.record_response(response_bytes)
+    with pytest.raises(Exception):
+        assert response.textfsm_parse_output(raise_err=True) == []
+
+
 def test_response_parse_textfsm_no_template():
     response = Response("localhost", channel_input="show ip arp", textfsm_platform="potato")
     response_bytes = b""