🚧 Convert to Typescript #120
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
commented
Jul 2, 2021
| "lint": "npm-run-all -c lint:*", | ||
| "lint:eslint": "eslint 'app/**/*.{js,ts}'", | ||
| "lint:tsc": "tsc --noEmit", | ||
| "server": "ts-node --transpile-only app/server.ts", |
There was a problem hiding this comment.
Consider an explicit build step instead of using ts-node in production.
mattbrictson
commented
Jul 2, 2021
| "start": "nodemon --watch . --watch .env.development --watch .env.development.local app/server.js", | ||
| "lint": "eslint 'app/**/*.js'", | ||
| "server": "node app/server.js", | ||
| "start": "ts-node-dev --transpile-only --watch .,.env.development,.env.development.local app/server.ts", |
There was a problem hiding this comment.
nodemon is a popular option.. is ts-node-dev well supported?
| "dotenv": "^10.0.0", | ||
| "@types/express": "^4.17.12", | ||
| "@types/jest": "^26.0.23", | ||
| "@types/lodash": "^4.14.170", |
There was a problem hiding this comment.
Do we really still need lodash? Especially since this project is now Node 16+ and typescript.
| "skipLibCheck": true, | ||
| "strict": true, | ||
| "target": "es2020" | ||
| } |
There was a problem hiding this comment.
Explicitly list excludes here (node_modules by default).
There was a problem hiding this comment.
Explicit includes as well.
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "compilerOptions": { | |||
There was a problem hiding this comment.
Make sure node and jest are included in types.
| "prettier": "^2.2.1", | ||
| "shelljs": "^0.8.2", | ||
| "supertest": "^6.1.3" | ||
| "supertest": "^6.1.3", | ||
| "ts-jest": "^27.0.3", |
There was a problem hiding this comment.
It would be great to have an example in the project of mocking a module in jest, and using the ts-jest utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP