Skip to content

Commit

Permalink
[Fix](regression test) Fix <=> rf cause regresion test failed (apache…
Browse files Browse the repository at this point in the history
  • Loading branch information
HappenLee authored Mar 18, 2024
1 parent d542248 commit 1a7bb08
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions be/src/exprs/runtime_filter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -303,10 +303,15 @@ class RuntimePredicateWrapper {
_context.hybrid_set->set_null_aware(params->null_aware);
break;
}
// Only use in nested loop join not need set null aware
case RuntimeFilterType::MIN_FILTER:
case RuntimeFilterType::MAX_FILTER:
case RuntimeFilterType::MAX_FILTER: {
_context.minmax_func.reset(create_minmax_filter(_column_return_type));
break;
}
case RuntimeFilterType::MINMAX_FILTER: {
_context.minmax_func.reset(create_minmax_filter(_column_return_type));
_context.minmax_func->set_null_aware(params->null_aware);
break;
}
case RuntimeFilterType::BLOOM_FILTER: {
Expand Down Expand Up @@ -1825,7 +1830,7 @@ Status RuntimePredicateWrapper::get_push_exprs(
// create max filter
TExprNode max_pred_node;
RETURN_IF_ERROR(create_vbin_predicate(probe_ctx->root()->type(), TExprOpcode::LE, max_pred,
&max_pred_node));
&max_pred_node, null_aware));
vectorized::VExprSPtr max_literal;
RETURN_IF_ERROR(create_literal(probe_ctx->root()->type(), _context.minmax_func->get_max(),
max_literal));
Expand All @@ -1842,7 +1847,7 @@ Status RuntimePredicateWrapper::get_push_exprs(
vectorized::VExprSPtr min_pred;
TExprNode min_pred_node;
RETURN_IF_ERROR(create_vbin_predicate(new_probe_ctx->root()->type(), TExprOpcode::GE,
min_pred, &min_pred_node));
min_pred, &min_pred_node, null_aware));
vectorized::VExprSPtr min_literal;
RETURN_IF_ERROR(create_literal(new_probe_ctx->root()->type(),
_context.minmax_func->get_min(), min_literal));
Expand Down

0 comments on commit 1a7bb08

Please sign in to comment.