Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added resolver directive #66

Merged
merged 3 commits into from
Nov 15, 2024
Merged

added resolver directive #66

merged 3 commits into from
Nov 15, 2024

Conversation

PietroPasotti
Copy link
Contributor

Fixes canonical/cos-lib#94

This change tells Nginx to update the IP whenever it changes.
To test:
deploy COS-lite plus Tempo HA.
refresh tempo worker with any locally packed charm
verify you can ping the /ready endpoint on port 3200 soon (max 5sec) after the new worker service has reported ready.

Copy link
Contributor

@mmkay mmkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One important overlook (running it with TLS), rest are rather cosmetic remarks.

src/nginx_config.py Outdated Show resolved Hide resolved
src/nginx_config.py Show resolved Hide resolved
src/nginx_config.py Outdated Show resolved Hide resolved
@PietroPasotti PietroPasotti requested a review from mmkay November 12, 2024 09:07
@PietroPasotti PietroPasotti merged commit 6d15deb into main Nov 15, 2024
14 checks passed
@PietroPasotti PietroPasotti deleted the fix-nginx-ip-change-restart branch November 15, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nginx may be missing a restart on worker refresh?
3 participants