Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secboot,fdestate,snap-bootstrap: use boot mode for FDE hooks #15049

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valentindavid
Copy link
Contributor

No description provided.

@valentindavid valentindavid added the Run nested The PR also runs tests inluded in nested suite label Feb 7, 2025
@valentindavid valentindavid reopened this Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Fri Feb 7 20:12:09 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13203581301

Failures:

Preparing:

  • openstack:debian-12-64:tests/unit/
  • google-nested:ubuntu-22.04-64:tests/nested/manual/core20-grade-signed-above-testkeys-boot:signed
  • google-nested:ubuntu-22.04-64:tests/nested/manual/recovery-system-offline:pre_installed_snaps
  • google-nested:ubuntu-22.04-64:tests/nested/manual/uc-update-assets-secure:both
  • google-nested:ubuntu-24.04-64:tests/nested/manual/hybrid-remodel
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64

Executing:

  • openstack:debian-12-64:tests/main/refresh:classic_remote
  • google-nested:ubuntu-22.04-64:tests/nested/manual/recovery-system:default
  • google-nested:ubuntu-22.04-64:tests/nested/core/core20-fault-inject-on-refresh:base_reboot_auto_connect
  • google-nested:ubuntu-22.04-64:tests/nested/manual/core20-early-config
  • google-nested:ubuntu-24.04-64:tests/nested/core/core22-basic:tokens
  • google-nested:ubuntu-24.04-64:tests/nested/core/core20-fault-inject-on-refresh:gadget_reboot_refresh_gadget_assets
  • google-nested:ubuntu-24.04-64:tests/nested/core/core20-fault-inject-on-refresh:base_reboot_link_snap
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:partial
  • google-nested:ubuntu-24.04-64:tests/nested/manual/remodel-min-size
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:seeded
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:encrypted
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-core:install_optional_snap_and_comp
  • google-arm:ubuntu-core-22-arm-64:tests/core/services
  • google-arm:ubuntu-20.04-arm-64:tests/main/install-remove-multi
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-helper
  • google:ubuntu-25.04-64:tests/main/cgroup-devices-v2
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-serial-port
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-self-manage
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:uinput
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-required-or-optional
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:kmsg
  • google:ubuntu-18.04-64:tests/main/snap-user-service-start-on-install

Restoring:

  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced

@valentindavid valentindavid force-pushed the valentindavid/fde-boot-modes branch from 084f35b to 49b1aa8 Compare February 7, 2025 16:08
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@752bed0). Learn more about missing BASE report.
Report is 177 commits behind head on master.

Files with missing lines Patch % Lines
secboot/secboot_hooks.go 57.14% 2 Missing and 1 partial ⚠️
overlord/fdestate/backend/reseal.go 0.00% 0 Missing and 2 partials ⚠️
secboot/secboot_dummy.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #15049   +/-   ##
=========================================
  Coverage          ?   78.08%           
=========================================
  Files             ?     1177           
  Lines             ?   156682           
  Branches          ?        0           
=========================================
  Hits              ?   122351           
  Misses            ?    26729           
  Partials          ?     7602           
Flag Coverage Δ
unittests 78.08% <76.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run nested The PR also runs tests inluded in nested suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant