progress: look at stdout rather than stdin when choosing a suitable meter #15038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a dedicated spread test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15038 +/- ##
=========================================
Coverage ? 77.99%
=========================================
Files ? 1150
Lines ? 153366
Branches ? 0
=========================================
Hits ? 119617
Misses ? 26374
Partials ? 7375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Fri Feb 7 10:41:56 UTC 2025 No spread failures reported |
…eter Look at stdout rather than stdin when trying to choose appropriate progress meter. The ensures that when snap is invoked under dpkg, it will emit progress regardless of stdin being closed/redirected. At the same time, do not produce a rich output when stdout is redirected. Signed-off-by: Maciej Borzecki <[email protected]>
bboozzoo
force-pushed
the
bboozzoo/progress-reporting
branch
from
8779a50 to
84f7092
Compare
bboozzoo
force-pushed
the
bboozzoo/progress-reporting
branch
from
84f7092 to
6d59585
Compare
Signed-off-by: Maciej Borzecki <[email protected]>
bboozzoo
force-pushed
the
bboozzoo/progress-reporting
branch
from
6d59585 to
3a918ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at stdout rather than stdin when trying to choose appropriate progress meter. The ensures that when snap is invoked under dpkg, it will emit progress regardless of stdin being closed/redirected. At the same time, do not produce a rich output when stdout is redirected.
Related: SNAPDENG-34147