Fix missing node name in cluster list #408
Merged
+177
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gboutry
requested changes
Jan 16, 2025
In case of machines deployed before migration from lxd based juju controller to k8s based juju controller, the hostname is missing in juju model status [1]. Because of which the cluster list command is broken and not showing node name. As a workaround for bug [1], if hostname is not available in model status compare dns-name with the IP address in microcluster status. If it matches update the node name and cluster status based on microcluster record. Fixes: #2095063 [1] juju/juju#18641
hemanthnakkina
force-pushed
the
fix-local-cluster-names
branch
from
9e3c5fa to
a1c3b32
Compare
gboutry
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of machines deployed before migration from lxd based juju controller
to k8s based juju controller, the hostname is missing in juju model status [1].
Because of which the cluster list command is broken and not showing node name.
As a workaround for bug [1], if hostname is not available in model status compare
dns-name with the IP address in microcluster status. If it matches update the node
name and cluster status based on microcluster record.
Fixes: LP#2095063
[1] juju/juju#18641