Add bootstrap option to prepare-node-script #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemanthnakkina
requested changes
Jan 13, 2025
gboutry
force-pushed
the
fix/prepare-node-bootstrap
branch
from
1b6aa6f to
dabb3c4
Compare
hemanthnakkina
requested changes
Jan 15, 2025
gboutry
force-pushed
the
fix/prepare-node-bootstrap
branch
2 times, most recently
from
557eb7b to
8c389a1
Compare
|
Functional test failed since lxdbr0 exists. I think the script should error out if if LXD is already bootstrapped and juju controller is bootstrapped on lxdbr0. If juju is not bootstrapped yet, it is ok to run bootstrap lxd ( Running lxd bootstrap multiple times works applying the last configuration set) |
gboutry
force-pushed
the
fix/prepare-node-bootstrap
branch
from
8c389a1 to
5489d9b
Compare
|
I've moved to always check if a lxdbr0 bridge exists. |
gboutry
force-pushed
the
fix/prepare-node-bootstrap
branch
from
5489d9b to
ab97ba8
Compare
hemanthnakkina
requested changes
Jan 16, 2025
gboutry
force-pushed
the
fix/prepare-node-bootstrap
branch
from
ab97ba8 to
12b7f98
Compare
Add bootstrap option on prepare-node-script to setup juju controller on LXD on primary node. Signed-off-by: Guillaume Boutry <[email protected]>
gboutry
force-pushed
the
fix/prepare-node-bootstrap
branch
from
12b7f98 to
7d4cf8e
Compare
hemanthnakkina
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bootstrap option on prepare-node-script to setup juju controller on LXD on primary node.