Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'plans list' not showing locked plans #393

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

MylesJP
Copy link

@MylesJP MylesJP commented Dec 20, 2024

The command 'sunbeam plans list' would previously only show unlocked terraform plans. On occasion a plan would be locked but not appear in the output of 'sunbeam plans list'. This change iterates over both the locked and unlocked plans to generate the output.

See: https://bugs.launchpad.net/snap-openstack/+bug/2092234

@hemanthnakkina hemanthnakkina merged commit 5b2988d into canonical:main Jan 6, 2025
6 checks passed
Copy link
Collaborator

@gboutry gboutry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very strange to me.

list_terraform_plans() is supposed to returned all terraform plans, and you can't lock a plan if it does not exist.

And this used to work correctly, did something change? Or is that happening in a specific edge case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants