Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove microk8s from sunbeam #374

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

MylesJP
Copy link

@MylesJP MylesJP commented Dec 5, 2024

No description provided.

@MylesJP MylesJP marked this pull request as ready for review December 5, 2024 18:14
@MylesJP MylesJP requested a review from gboutry December 5, 2024 23:48
gboutry
gboutry previously approved these changes Dec 10, 2024
Copy link
Collaborator

@gboutry gboutry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, just need a rebase, you can take these comments into consideration then

sunbeam-python/sunbeam/provider/maas/commands.py Outdated Show resolved Hide resolved
sunbeam-python/sunbeam/provider/maas/commands.py Outdated Show resolved Hide resolved
@gboutry gboutry dismissed their stale review December 10, 2024 08:57

request changes

@MylesJP MylesJP force-pushed the remove-microk8s branch 2 times, most recently from 4c42656 to ea7e56c Compare December 10, 2024 16:08
.github/workflows/test-snap.yml Outdated Show resolved Hide resolved
sunbeam-python/sunbeam/core/k8s.py Outdated Show resolved Hide resolved
@hemanthnakkina hemanthnakkina merged commit f0928dd into canonical:main Dec 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants