Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: release notes for 1.7.0 #776

Merged
merged 12 commits into from
Dec 20, 2024
Merged

docs: release notes for 1.7.0 #776

merged 12 commits into from
Dec 20, 2024

Conversation

tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Dec 17, 2024

  • Have you signed the CLA?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 17, 2024
tigarmo
tigarmo commented Dec 17, 2024
View reviewed changes
docs/release-notes/index.rst Outdated Show resolved Hide resolved
@tigarmo tigarmo requested a review from medubelko December 17, 2024 22:05
medubelko
medubelko requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I did a deeper review of this, because I want to ensure we're off on the right foot.

I agree with your selection of major and minor changes. We'll have better examples to provide to other projects once we have more releases to document.

docs/release-notes/rockcraft-1-7-0.rst Outdated Show resolved Hide resolved
docs/release-notes/rockcraft-1-7-0.rst Outdated Show resolved Hide resolved
docs/release-notes/rockcraft-1-7-0.rst Outdated Show resolved Hide resolved
docs/release-notes/rockcraft-1-7-0.rst Outdated Show resolved Hide resolved
docs/release-notes/rockcraft-1-7-0.rst Outdated Show resolved Hide resolved
docs/release-notes/rockcraft-1-7-0.rst Outdated Show resolved Hide resolved
docs/release-notes/rockcraft-1-7-0.rst Outdated Show resolved Hide resolved
docs/release-notes/rockcraft-1-7-0.rst Outdated Show resolved Hide resolved
docs/release-notes/rockcraft-1-7-0.rst Outdated Show resolved Hide resolved
docs/release-notes/rockcraft-1-7-0.rst Outdated Show resolved Hide resolved
@tigarmo tigarmo requested a review from medubelko December 19, 2024 12:24
@tigarmo tigarmo marked this pull request as ready for review December 19, 2024 12:25
@tigarmo tigarmo requested a review from a team December 19, 2024 12:26
medubelko
medubelko requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three small things, then I think we're good to go.

docs/release-notes/rockcraft-1-7-0.rst Outdated Show resolved Hide resolved
docs/release-notes/rockcraft-1-7-0.rst Outdated Show resolved Hide resolved
docs/release-notes/index.rst Outdated Show resolved Hide resolved
medubelko
medubelko approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨 on. Many thanks for being the test subject.

@tigarmo tigarmo added the squash label Dec 19, 2024
medubelko
medubelko approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-approving.

bepri
bepri approved these changes Dec 19, 2024
View reviewed changes
Copy link

@bepri bepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great - I'm a big fan of this format!

@tigarmo tigarmo merged commit 41b2368 into main Dec 20, 2024
13 checks passed
@tigarmo tigarmo deleted the release/1.7.0 branch December 20, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medubelko medubelko medubelko approved these changes

@bepri bepri bepri approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tigarmo @bepri @medubelko