forked from openebs/rawfile-localpv
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update helm charts to handle rockcraft and a different storage.path #2
Merged
addyess
merged 4 commits into
rockcraft
from
KU-275-update-rawfile-localpv-chart-to-specify-a-custom-host-directory
Feb 2, 2024
Merged
Update helm charts to handle rockcraft and a different storage.path #2
addyess
merged 4 commits into
rockcraft
from
KU-275-update-rawfile-localpv-chart-to-specify-a-custom-host-directory
Feb 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
commented
Jan 31, 2024
addyess
commented
Jan 31, 2024
addyess
commented
Jan 31, 2024
neoaggelos
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first pass of comments
addyess
force-pushed
the
KU-275-update-rawfile-localpv-chart-to-specify-a-custom-host-directory
branch
from
February 1, 2024 17:49
b53a23e
to
9eb71c3
Compare
addyess
force-pushed
the
KU-275-update-rawfile-localpv-chart-to-specify-a-custom-host-directory
branch
from
February 1, 2024 17:49
9eb71c3
to
9fe4698
Compare
neoaggelos
reviewed
Feb 1, 2024
neoaggelos
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
addyess
deleted the
KU-275-update-rawfile-localpv-chart-to-specify-a-custom-host-directory
branch
February 2, 2024 14:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameterize the storage path location, and if the image is the canonical rockcraft based image, launch with pebble arguments
Installation of the rockcraft image:
sudo k8s helm install -n kube-system \ --set controller.image.repository=ghcr.io/canonical/rawfile-localpv \ --set node.image.repository=ghcr.io/canonical/rawfile-localpv \ --set node.storage.path=/var/snap/k8s/common/local-storage \ --set serviceMonitor.enabled=false \ --set node.image.tag=0.8.0-ck1 \ --set controller.image.tag=0.8.0-ck1 \ --set controller.csiDriverArgs='{--args,rawfile,csi-driver,--disable-metrics}' \ rawfile-csi ./deploy/charts/rawfile-csi/