Fix Event field name ("name" -> "path") #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, when testing secret events we get a TypeError: > return Event(name="secret_changed", secret=self) E TypeError: Event.__init__() got an unexpected keyword argument 'name'
There was a problem hiding this comment.
this is also fixed in #90 already, along with more tests for these paths.
Will merge v6 today
|
Oops, sorry, I'd forgotten about those fixes (and that they were on a different branch). Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, when using
Secret.changed_eventand similar properties, aTypeErroris raised:Probably means there should be tests of these code paths too, but I'm too lazy to add that here -- just flagging the issue. :-)