Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename Relation.relation_id to Relation.id #113

Merged
merged 2 commits into from
May 22, 2024

Conversation

tonyandrewmeyer
Copy link
Collaborator

Renames Relation.relation_id to Relation.id for consistency (e.g. with Secret.id and Action.id) and as a more concise name that doesn't repeat its namespace.

@tonyandrewmeyer tonyandrewmeyer marked this pull request as ready for review May 22, 2024 00:05
@PietroPasotti PietroPasotti merged commit e758e78 into canonical:main May 22, 2024
2 checks passed
PietroPasotti added a commit that referenced this pull request May 29, 2024
@PietroPasotti
Copy link
Collaborator

this was mistakenly merged into main and released with a minor bump

@PietroPasotti
Copy link
Collaborator

manually merged into 7.0 and rolled it back from main #131

@tonyandrewmeyer tonyandrewmeyer deleted the rename-relation-id branch May 30, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants