-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct the consistency checker's config "type" validation #106
fix: correct the consistency checker's config "type" validation #106
Conversation
Oh, and thanks for this, Tony -- appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits and grits but it looks good!
Might be a good chance to get rid of that commented-out attrs
question mark too?
I'm sure there was an attrs type in some document at some point, but I can't find it anymore so we can probably safely get rid of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice! thanks a lot :)
Some small corrections to the consistency checker's validation of the
type
field in config:Adjust tests to match.
See also canonical/operator#1166 for
type:secret
issue inHarness
.