Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use default_factory to provide default UUID and name values for Model #105

Merged

Conversation

tonyandrewmeyer
Copy link
Collaborator

Currently, Scenario defaults Model.name and Model.uuid to the same (random) value across all instances. This PR changes the class to use a dataclasses.field default_factory instead, so that each instance gets a unique (random) default.

Copy link
Collaborator

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@PietroPasotti PietroPasotti merged commit d69e183 into canonical:main Mar 22, 2024
2 checks passed
@tonyandrewmeyer tonyandrewmeyer deleted the fix-model-attr-defaults branch March 26, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants