Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: PietroPasotti <[email protected]>
  • Loading branch information
tonyandrewmeyer and PietroPasotti authored Aug 5, 2024
1 parent 0d2cf9f commit 2ec2256
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scenario/mocking.py
Original file line number Diff line number Diff line change
Expand Up @@ -514,13 +514,13 @@ def secret_remove(self, id: str, *, revision: Optional[int] = None):
raise ValueError(
"Charms should not remove the latest revision of a secret. "
"Add a new revision with `set_content()` instead, and the previous "
"revision will be garbage collected when no longer used.",
"revision will be cleaned up by the secret owner when no longer in use.",
)

# For all other revisions, the content is not visible to the charm
# (this is as designed: the secret is being removed, so it should no
# longer be in use). That means that the state does not need to be
# modified - however, unit tests should verify that the remove call was
# modified - however, unit tests should be able to verify that the remove call was
# executed, so we track that in a history list in the context.
self._context.removed_secret_revisions.append(revision)

Expand Down

0 comments on commit 2ec2256

Please sign in to comment.