Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix link to Juju docs in Kubernetes charm tutorial #1529

Merged
merged 2 commits into from
Jan 16, 2025
Merged

docs: fix link to Juju docs in Kubernetes charm tutorial #1529

merged 2 commits into from
Jan 16, 2025

Conversation

dwilding
Copy link
Contributor

This PR fixes the link to Juju on this page: https://ops.readthedocs.io/en/latest/tutorial/from-zero-to-hero-write-your-first-kubernetes-charm/set-up-your-development-environment.html

Fixed issues:

  • The link points to "Tear down automatically" in the Juju instructions. It should point to the full instructions for setting up automatically.
  • The link doesn't render properly because of a missing ) at the end.

@dwilding
Copy link
Contributor Author

@james-garner-canonical one very small Ops PR for review, when you have time. No rush. Thanks!

tonyandrewmeyer
tonyandrewmeyer approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tonyandrewmeyer
Copy link
Contributor

Re-running the failing job (#1524 - seems to be happening much more frequently than before).

@dwilding dwilding merged commit d180ad2 into canonical:main Jan 16, 2025
32 checks passed
@dwilding dwilding deleted the fix-md-link branch January 16, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-garner-canonical james-garner-canonical james-garner-canonical approved these changes

@tonyandrewmeyer tonyandrewmeyer tonyandrewmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwilding @tonyandrewmeyer @james-garner-canonical