-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix broken links and use cross references instead of absolute links #1519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! It's really nice how simple it is do the the links now - much more straightforward than when they were on Discourse.
This PR addresses #1506
Changes that affect the published docs
Fixed links that broke after the library docs were moved under Reference. See 8d62861 (for Harness-related links) and 1d8374e (for other links). For some of the Harness-related links, I set the links to use the full doc title "ops.testing.Harness (legacy unit testing)" to help emphasise that Harness is legacy.
In How to run workloads with a charm - Kubernetes, fixed a link to
ops.Container.isdir
. See b5d5528In Manage relations, fixed a link to
ops.RelationChangedEvent
. See a2e84e9Changes that affect the doc source only
Replaced absolute links to
ops.testing
by a cross reference to the ops.testing page. See a375749. The .rst source for this page defines a reference calledops_testing
, so I've used this format for links from .md pages:Replaced links to classes, methods, etc by cross references. See:
ops.testing
ops.pebble
ops.Container
References like
ops.foo.bar
are generated byautomodule
/autoclass
directives in the .rst source files. If a link doesn't need custom link text, we automatically get code font when doing[](ops.foo.bar)
in .md files.