Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken links and use cross references instead of absolute links #1519

Merged
merged 9 commits into from
Jan 9, 2025

Conversation

dwilding
Copy link
Contributor

@dwilding dwilding commented Jan 2, 2025

This PR addresses #1506

Changes that affect the published docs

Changes that affect the doc source only

  • Replaced absolute links to ops.testing by a cross reference to the ops.testing page. See a375749. The .rst source for this page defines a reference called ops_testing, so I've used this format for links from .md pages:

    [Link title](ops_testing)
    
  • Replaced links to classes, methods, etc by cross references. See:

    References like ops.foo.bar are generated by automodule/autoclass directives in the .rst source files. If a link doesn't need custom link text, we automatically get code font when doing [](ops.foo.bar) in .md files.

@dwilding dwilding changed the title docs: fix broken links and use cross references instead of absolite links docs: fix broken links and use cross references instead of absolute links Jan 2, 2025
@dwilding dwilding marked this pull request as ready for review January 3, 2025 08:07
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! It's really nice how simple it is do the the links now - much more straightforward than when they were on Discourse.

@dwilding dwilding merged commit 02197b3 into canonical:main Jan 9, 2025
34 checks passed
@dwilding dwilding deleted the update-internal-links branch January 9, 2025 00:09
@dwilding dwilding linked an issue Jan 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make internal doc links references
3 participants