ci: don't cancel other unit tests when one fails #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test can pass on one python/os version and fail on others, and it’s nice to see that in the outcome, rather than dig into cancelled tests which may or may not have hit the failing case. Since unit tests are cheap and fast, we’re not really saving much by cancelling them – by the time one unit test run fails and asks the others to cancel, they’ll already have been spun up and run many of the tests, so canceling them doesn't save much. The pip-install and test-real-pebble jobs are faster than the test job, so this commit adds fail-fast: false to them too. Note: test with macos-latest and python 3.10 is the slowest by far.
dimaqq
approved these changes
Nov 28, 2024
tonyandrewmeyer
approved these changes
Nov 28, 2024
benhoyt
approved these changes
Nov 28, 2024
|
We can wait till after the release to merge this |
IronCore864
approved these changes
Nov 28, 2024
@james-garner-canonical want to push the big green button now? 😄 |
|
Or now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test can pass on one python/os version and fail on others, and it’s nice to see that in the outcome, rather than dig into cancelled tests which may or may not have hit the failing case.
Since unit tests are cheap and fast, we’re not really saving much by cancelling them – by the time one unit test run fails and asks the others to cancel, they’ll already have been spun up and run many of the tests, so cancelling them doesn't save much.
The pip-install and test-real-pebble jobs are faster than the test job, so this commit adds fail-fast: false to them too.