Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the executable bit from all the .py files #1059

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

jameinel
Copy link
Member

@jameinel jameinel commented Nov 8, 2023

None of these are run as scripts, and aren't meant to be executable.

(Note that src/charm.py would be executable, but that is the user script, not the ops internal libraries)

None of these are run as scripts, and aren't meant to be executable.
@benhoyt
Copy link
Collaborator

benhoyt commented Nov 8, 2023

Thanks! Additionally see below (though if you don't get a chance to do it, one of us can do it before we merge).

These should also have their x bit removed:

-rwxrwxr-x  1 ben ben  30676 Oct 12 06:36 test_charm.py*
-rwxrwxr-x  1 ben ben  68893 Oct  5 05:39 test_framework.py*
-rwxrwxr-x  1 ben ben   5253 Oct  5 05:39 test_helpers.py*
-rwxrwxr-x  1 ben ben   7990 Oct  5 05:39 test_jujuversion.py*
-rwxrwxr-x  1 ben ben  51001 Oct  5 05:39 test_main.py*
-rwxrwxr-x  1 ben ben 145152 Oct 26 22:10 test_model.py*
-rwxrwxr-x  1 ben ben  15809 Oct  5 05:39 test_storage.py*

And these should have their hash-bang lines removed, as we don't (and probably can't in most cases) run tests this way:

test/test_log.py
1:#!/usr/bin/python3

test/test_real_pebble.py
1:#!/usr/bin/python3

test/test_pebble.py
1:#!/usr/bin/python3

test/test_model.py
1:#!/usr/bin/python3

Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See above comment -- but if you don't get to this, no problem! We'll do it before merging.

@tonyandrewmeyer
Copy link
Contributor

These should also have their x bit removed:

Done.

And these should have their hash-bang lines removed, as we don't (and probably can't in most cases) run tests this way:

Done.

@tonyandrewmeyer tonyandrewmeyer changed the title Remove the executable bit from all the .py files. chore: remove the executable bit from all the .py files Nov 9, 2023
@tonyandrewmeyer tonyandrewmeyer added feature New feature or request small item labels Nov 9, 2023
@benhoyt benhoyt merged commit 848fb52 into canonical:main Nov 9, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request small item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants