-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add database package #216
Add database package #216
Conversation
BenchmarkResults
Current status
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Marco! I love the direction this is going. This helps code readability greatly.
I've left some first questions and comments.
91ebeac
to
13de1f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, a few minor questions and comments:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Marco! Thanks for addressing my comments 🚀
This PR moves the
prepared
package and the implementation of prepared to a dedicated and more genericdatabase
package, so that it is possible to add other wrappers that add functionality on the way.This was part of #180 and was split out so that the PR is smaller, and other functionality can use the right interface even if batching is not merged yet.
This PR does not change functionality and should not affect performance in any way.
Also, there is a small difference from the original version of this code in #180:
Wrap
method is no longer required for this to work, insteadNewPrepared
accepts a generic interface and acts as the wrapper itself. If this PR gets in this change will be reflected in #180 as well.