Add concurrency to create/update/insert benchmarks #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultCurrent status |
There was a problem hiding this comment.
Thanks a lot @marco6! I don't know anything about k8s dqlite, so please treat my minor comments as probably-not-so-important-and-just-out-of-curiosity
|
We are limited in the output of the benchmark test if I remember correctly? We can't combine the results of say the create run, right? |
Merged
As discussed on MM, we decided to change the naming of the tests as it was quite confusing. We are keeping them separated so that we can see how it behaves under different kind of loads. |
louiseschmidtgen
approved these changes
Sep 10, 2024
Because the matching is done on the name. The While the new set has none of those and new ones. As such, they cannot be compared. This is also the reason why #170 needs to be rebased once this is in (a merge would not work from the PoV of benchmarking). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single threading benchmarking is interesting, but it is also necessary to understand how the system behaves in the face of multiple concurrent clients contenting the database.
This PR adds concurrency to the write path, while keeping operations distinct (i.e. no mixed create/update/delete load). While still a synthetic load, it can be considered "closer to reality".