Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DoCompact operation interruptible #111

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Make DoCompact operation interruptible #111

merged 1 commit into from
Jul 1, 2024

Conversation

marco6
Copy link
Collaborator

@marco6 marco6 commented Jun 27, 2024

This PR aims at making the DoCompact operation interruptible from the outside, so that it is easier to test.

@marco6 marco6 requested a review from a team as a code owner June 27, 2024 06:50
@marco6 marco6 mentioned this pull request Jun 27, 2024
Merged
bschimke95
bschimke95 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marco6
Copy link
Collaborator Author

marco6 commented Jul 1, 2024

As discussed on MM, we can merge even if Trivy scan is failing.

@marco6 marco6 merged commit 8594487 into canonical:master Jul 1, 2024
16 of 18 checks passed
@marco6 marco6 deleted the interruptible-compact branch July 1, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschimke95 bschimke95 bschimke95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marco6 @bschimke95