Pin urllib3 to support running on [email protected] #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanchiwai-ray
requested review from
Vultaire,
Pjack,
aieri,
samuelallan72,
jneo8,
gabrielcocenza and
Deezzir
samuelallan72
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
LGTM. I agree that splitting the bases is the long term solution, but as you mentioned in a separate discussion, this may need to wait until we officially add charmcraft 3 support (#294).
Pjack
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin
urllib3 < 2.3.0to support running on [email protected] because the latest urllib3 does not support Python 3.8 anymore: https://github.com/urllib3/urllib3/blob/main/CHANGES.rst#230-2024-12-22.However, we should consider split the charm to build and run on the same environment.
Fix CI failure on [email protected] base.