Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix realhw functests #382

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Fix realhw functests #382

merged 6 commits into from
Jan 17, 2025

Conversation

aieri
Copy link
Contributor

@aieri aieri commented Dec 21, 2024

This commit attempts at fixing "realhw" functional tests, specifically for the following scenario:

tox -e func -- -v --realhw --model test --collectors ipmi_dcmi ipmi_sel ipmi_sensor --base [email protected] --nvidia --keep-models

List of changes:

  • Move rendering the bundle to a fixture and disable redfish if the collector isn't listed - this avoids tests complaining about incorrect redfish credentials when you're not interested in testing redfish anyway
  • Update README to consider the work we did in dev-environment.md to be able to run tests on a single machine
  • Fix incorrect hardware-exporter config search path

@aieri aieri changed the title fix functests Fix realhw functests Dec 21, 2024
@aieri
Copy link
Contributor Author

aieri commented Dec 21, 2024

Sorry I ran out of time so this remains a work in progress if someone wants to continue this work. test_cos_agent_relation fails for me for reasons I don't understand.

@chanchiwai-ray chanchiwai-ray marked this pull request as ready for review January 13, 2025 03:22
@chanchiwai-ray chanchiwai-ray requested a review from a team as a code owner January 13, 2025 03:22
@Deezzir
Copy link
Contributor

Deezzir commented Jan 15, 2025

I might come back to this PR and continue the work. I already fixed some of the test, so I have some context. We can postpone the merge for now.

@chanchiwai-ray
Copy link
Contributor

chanchiwai-ray commented Jan 17, 2025

I might come back to this PR and continue the work. I already fixed some of the test, so I have some context. We can postpone the merge for now.

Do you plan to add more tests? Currently, the test worked for me tox -e func -- -v --realhw --model test --collectors ipmi_dcmi ipmi_sel ipmi_sensor --base [email protected] --nvidia --keep-models : https://pastebin.ubuntu.com/p/HSg6JBpyVw/

@chanchiwai-ray chanchiwai-ray merged commit 460215d into canonical:main Jan 17, 2025
10 checks passed
@aieri aieri deleted the fix-functests branch January 17, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants