Make stored_tools a property #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By making stored_tools a property we avoid the awkwardness of having to continuously convert back and forth between Set[HWTool] and Set[str] (which can be handled by StoredState)
aieri
requested review from
Vultaire,
Pjack,
samuelallan72,
jneo8,
gabrielcocenza,
Deezzir and
sbparke
Deezzir
previously approved these changes
Dec 11, 2024
gabrielcocenza
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making stored_tools a property we avoid the awkwardness of having to
continuously convert back and forth between Set[HWTool] (which cannot be handled by
StoredState) and Set[str] (which can)