tests: Add hw dependent tests for redfish cred validation #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `test_redfish_credential_validation` which sets the redfish credentials and checks if the charm is funtioning as intended. `test_build_and_deploy` is broken up into smaller tests so that they are easier to manage. Also modifies logic in conftest.py so that all these tests are executed whether they're hw dependent or independent. `test_redfish_metrics` has also been modified since we are setting the redfish credentials as part of the earlier test. Finally, a retry mechanism has been added to `test_metrics_available` as it was found while testing that it takes some time for the endpoint to be ready with the metrics.
dashmage
force-pushed
the
bseng-2192-update-hw-dep-tests
branch
from
4f7842c to
c45fd97
Compare
jneo8
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
test_redfish_credential_validationwhich sets the redfish credentials and checks if the charm is funtioning as intended. This is necessary for hardware dependent tests since the charm only goes to active state once the correct redfish credentials are configured (assuming redfish is present on the underlying machine).test_build_and_deployis broken up into smaller tests so that they are easier to manage. Also modifies logic in conftest.py so that all these tests are executed whether they're hw dependent or independent.test_redfish_metricshas also been modified since we are setting the redfish credentials as part of the earlier test. The resource based tests (test_resource_in_correct_location,test_wrong_resource_attachedandtest_resource_clean_up) have been moved towards the end ofTestCharmWithHWso that all the metrics based tests can be grouped together in the beginning.Finally, a retry mechanism has been added to
test_metrics_availableas it was found while testing that it takes some time for the endpoint to be ready with the metrics.Note: Requires #192 to be merged.