refactor: Collect all status in one place #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dashmage
commented
Mar 22, 2024
dashmage
commented
- Set all statuses from the collect_unit_status event handler.
- Change name from exporter_enabled to relation_present
- Refactor code into render_exporter_config
- Change return format for validate_exporter_configs to be simpler.
|
A lot of unit tests break with this change. Once the overall logic is finalized, I'll go ahead and make the required unit test modifications. |
|
I'm thinking whether I should make changes to resolve #201 as well since I'm anyway changing the stored state variables with this PR. |
Comment on lines
-77
to
-78
| exporter_installed=False, | ||
| resource_installed=False, |
There was a problem hiding this comment.
It's better that we avoid using store for *_installed here, and create methods to directly verify them
* Set all statuses from the collect_unit_status event handler. * Change name from exporter_enabled to relation_present * Refactor code into render_exporter_config * Change return format for validate_exporter_configs to be simpler.
dashmage
force-pushed
the
bseng-2199-collect-status
branch
from
3f0f931 to
24bf362
Compare
|
Close this PR, since it was pending for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.