Add Harbor *photon Rock images #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
aznashwan
suggested changes
Jul 10, 2024
aznashwan
reviewed
Jul 10, 2024
| useradd -R $CRAFT_OVERLAY \ | ||
| --no-log-init -r -m -g 10000 -u 10000 harbor | ||
|
|
||
| registry: |
There was a problem hiding this comment.
FYI, the registryctl image embeds the registry binary too for some reason so I'm just gonna blindly copy this part from you 👼
petrutlucian94
force-pushed
the
photon
branch
4 times, most recently
from
4e592d0 to
42ce17a
Compare
The Harbor project has some Photon-OS based images: * docker.io/goharbor/nginx-photon:v2.10.2 * docker.io/goharbor/registry-photon:v2.10.2 * docker.io/goharbor/trivy-adapter-photon:v2.10.2 * docker.io/goharbor/redis-photon:v2.10.2 * docker.io/goharbor/harbor-portal:v2.10.2 We're defining Rock drop-in replacements, which obviously will not be Photon based. Note that the reference images have an install_cert.sh script that is a no-op on non-Photon images. We're keeping it for now, mostly for consistency.
Rockcraft does not allow two parts to stage the same files with different content. In our case, the nginx package includes a sample at /usr/share/nginx/html that has to be removed.
We'll skip adding the node_modules dir to $PATH. At the same time, we'll no longer install ng-swagger-gen explicitly, expecting it to be retrieved as part of the build process.
On Ubuntu 22.04 with snap installed nodejs, one of the portal dependencies fails to install: cypress-io/cypress-documentation#5868 We'll apply the recommended workaround.
|
@petrutlucian94 please feel free to close this since it was superseded by #12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Harbor project has some Photon-OS based images:
We're defining Rock drop-in replacements, which obviously will not be Photon based.
Note that the reference images have an install_cert.sh script that is a no-op on non-Photon images. We're keeping it for now, mostly for consistency.