Skip to content

Commit

Permalink
if the image builder does not go to active or goes to error, fail
Browse files Browse the repository at this point in the history
  • Loading branch information
javierdelapuente committed Jan 29, 2025
1 parent b5d8a84 commit 147313e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class ReconcileRunnersEvent(EventBase):


def catch_charm_errors(
func: Callable[["GithubRunnerCharm", EventT], None]
func: Callable[["GithubRunnerCharm", EventT], None],
) -> Callable[["GithubRunnerCharm", EventT], None]:
"""Catch common errors in charm.
Expand Down Expand Up @@ -145,7 +145,7 @@ def func_with_catch_errors(self: "GithubRunnerCharm", event: EventT) -> None:


def catch_action_errors(
func: Callable[["GithubRunnerCharm", ActionEvent], None]
func: Callable[["GithubRunnerCharm", ActionEvent], None],
) -> Callable[["GithubRunnerCharm", ActionEvent], None]:
"""Catch common errors in actions.
Expand Down
4 changes: 3 additions & 1 deletion tests/integration/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,9 @@ async def app_openstack_runner_fixture(
wait_idle=False,
)
await model.integrate(f"{image_builder.name}:image", f"{application.name}:image")
await model.wait_for_idle(apps=[application.name], status=ACTIVE, timeout=90 * 60)
await model.wait_for_idle(
apps=[application.name, image_builder.name], status=ACTIVE, timeout=90 * 60
)

return application

Expand Down

0 comments on commit 147313e

Please sign in to comment.