review: Different handling for empty contributors

canonical · Jan 21, 2025 · abc4d8c · abc4d8c
1 parent d02e878
commit abc4d8c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/profiles_management/helpers/kfam.py b/src/profiles_management/helpers/kfam.py
@@ -283,7 +283,10 @@ def create_rolebindings_for_profile_contributors(
     existing_rolebindings = list_contributor_rolebindings(client, profile.name)
     existing_contributor_roles = kfam_resources_list_to_roles_dict(existing_rolebindings)
 
-    for contributor in profile.contributors or []:
+    if not profile.contributors:
+        return
+
+    for contributor in profile.contributors:
         if contributor.role not in existing_contributor_roles.get(contributor.name, []):
             log.info("Will create RoleBinding for Contributor: %s", contributor)
             client.apply(generate_contributor_rolebinding(contributor, profile.name))