feat: first iteration of C client library #636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #636 +/- ##
==========================================
+ Coverage 81.21% 81.38% +0.16%
==========================================
Files 192 195 +3
Lines 27061 26198 -863
Branches 4943 4660 -283
==========================================
- Hits 21978 21320 -658
+ Misses 3445 3281 -164
+ Partials 1638 1597 -41 ☔ View full report in Codecov by Sentry. |
cole-miller
suggested changes
Apr 17, 2024
| static char *bools[] = {"0", "1", NULL}; | ||
|
|
||
| static MunitParameterEnum client_params[] = { | ||
| {"disk_mode", bools}, |
There was a problem hiding this comment.
I would just ditch the disk mode param since the old disk mode is going away
There was a problem hiding this comment.
This file is copied from existing tests, just renamed to better reflect what it is still testing. Should I remove the param before the old disk mode goes away?
|
This is not a priority for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.