Refactor vfs2 #631
Merged
Refactor vfs2 #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The headline change is that almost everything now lives in the entry, but various other changes were swept up in this as well. Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
This happens when we start up and then transition to leader before writing the first WAL header. Signed-off-by: Cole Miller <[email protected]>
We can't "pass through" BASE while the write lock is held with the current invariant, and I don't want to relax the write lock check. Signed-off-by: Cole Miller <[email protected]>
Now we are sometimes in the ACTIVE state when the current transaction still has zero frames. Signed-off-by: Cole Miller <[email protected]>
Part of the ripple from fixing the BASE transitions. Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
This happens when we do a checkpoint. Part of the "EMPTY reform". Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dqlite-next #631 +/- ##
===============================================
- Coverage 81.15% 80.56% -0.60%
===============================================
Files 194 196 +2
Lines 28045 28300 +255
Branches 5211 5297 +86
===============================================
+ Hits 22761 22799 +38
- Misses 3586 3808 +222
+ Partials 1698 1693 -5 ☔ View full report in Codecov by Sentry. |
|
@just-now I would like to merge this into dqlite-next and follow up with additional tests/fixes in future, smaller PRs. |
just-now
reviewed
Apr 15, 2024
Comment on lines
+263
to
+267
| struct sqlite3_file base; | ||
| /* Flags passed to the xOpen that created this file. */ | ||
| int flags; | ||
| /* File object created by the base (unix) VFS. Not used for WAL. */ | ||
| sqlite3_file *orig; |
There was a problem hiding this comment.
nit: Can we use either struct sqlite3_file or just sqlite3_file?
There was a problem hiding this comment.
Needs to be a pointer since the size of sqlite3_file doesn't reflect the size of the file object created by the unix VFS -- it adds its own fields afterward just like we do with our struct file
just-now
reviewed
Apr 15, 2024
cole-miller
force-pushed
the
vfs2-recovery
branch
from
ec86147 to
2212a5d
Compare
Signed-off-by: Cole Miller <[email protected]>
cole-miller
force-pushed
the
vfs2-recovery
branch
from
2212a5d to
c7464b5
Compare
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
Signed-off-by: Cole Miller <[email protected]>
just-now
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headline change is that almost everything now lives in the linked-list entry, but various other changes were swept up in this as well.
Still incomplete, the state machine needs to be updated along with the implementations of the vfs2.h functions and quite a few smaller TODOs that I've tried to note in the code for my own benefit.
The big refactor was motivated by thinking in more detail about how the WAL-index is going to be managed throughout the node's whole lifetime, including the "follower" part that I'd previously neglected. I think I now have a good mental model for this, which I intend to write down as a doc comment on the state machine stuff once that is brought up to date/stabilized.
Signed-off-by: Cole Miller [email protected]