replace monitor_cb by raft state_cb. #543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu Borderé <[email protected]>
|
please test downstream |
The state_cb is called immediately after raft's state changes, while the monitor_cb was polling every loop iteration. This led e.g. to bugs where raft was assuming no longer being the leader while dqlite's state was not properly reflecting that. Signed-off-by: Mathieu Borderé <[email protected]>
MathieuBordere
force-pushed
the
state-cb
branch
from
820644b to
2e93f67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state_cb is called immediately after raft's state changes, while the
monitor_cb was polling every loop iteration. This led e.g. to bugs where
raft was assuming no longer being the leader while dqlite's state was not
properly reflecting that.
Fixes #541 , also please refer to that issue for the problem description. Issue observed was similar as in #355.
Relies on functionality introduced by canonical/raft#488.