Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't mount cache directories in lxd base instances #473

Merged
merged 3 commits into from
Dec 4, 2023
Merged

fix: don't mount cache directories in lxd base instances #473

merged 3 commits into from
Dec 4, 2023

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Dec 1, 2023 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@lengau lengau requested review from mr-cal and syu-w December 1, 2023 17:16
This was referenced Dec 1, 2023
Merged
Merged
mr-cal
mr-cal approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a unit test needs adjusting and tox run -m format.

craft_providers/base.py Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b885aea) 99.00% compared to head (7074e73) 99.00%.

Additional details and impacted files 
@@             Coverage Diff              @@
##           hotfix/1.19     #473   +/-   ##
============================================
  Coverage        99.00%   99.00%           
============================================
  Files               57       57           
  Lines             4527     4528    +1     
============================================
+ Hits              4482     4483    +1     
  Misses              45       45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lengau lengau merged commit 0089540 into hotfix/1.19 Dec 4, 2023
13 checks passed
@lengau lengau deleted the aml/hotfix-base-cache branch December 4, 2023 17:01
@lengau lengau mentioned this pull request Dec 4, 2023
Closed
lengau added a commit that referenced this pull request Apr 11, 2024
@lengau
fix: don't mount cache directories in lxd base instances (#473)
bfee962 
(cherry picked from commit 0089540)
mr-cal pushed a commit that referenced this pull request Apr 11, 2024
@lengau @mr-cal
fix: don't mount cache directories in lxd base instances (#473)
163f560 
(cherry picked from commit 0089540)
lengau added a commit that referenced this pull request Apr 12, 2024
@mr-cal @lengau
chore(merge): '1.20.3' into 'main' (#552)
eea1f62 
* fix: don't mount cache directories in lxd base instances (#473)

(cherry picked from commit 0089540)

* chore(bases): bump compatibility tag to v8

This is the lowest unused compatibility flag.

* docs(changelog): add 1.20.3 release notes

---------

Co-authored-by: Alex Lowe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syu-w syu-w syu-w approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lengau @mr-cal @syu-w