ci(github): disable fast failure for integration tests #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one flaky linux integration test fails, do not automatically cancel the other integration tests in the test matrix. Signed-off-by: Callahan Kovacs <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 57 57
Lines 4532 4532
=======================================
Hits 4487 4487
Misses 45 45 ☔ View full report in Codecov by Sentry. |
syu-w
approved these changes
Nov 29, 2023
|
Maybe add macOS? |
lengau
approved these changes
Nov 29, 2023
There's only one macos test and it's a different job, so it shouldn't preemptively cancel other tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?Currently, we run 4 integration tests on Linux runners, each for a different version of python.
Often, 1 flaky test will fail and cause all 4 jobs to be canceled. This is time-consuming for the developer and uses a lot more runners than needed.