Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(ci): add weekly slow tests for macOS #460

Merged
merged 3 commits into from
Nov 29, 2023
Merged

tests(ci): add weekly slow tests for macOS #460

merged 3 commits into from
Nov 29, 2023

Conversation

syu-w
Copy link
Contributor

@syu-w syu-w commented Nov 22, 2023

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d64bc43) 99.00% compared to head (866b3c0) 99.00%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          57       57           
  Lines        4532     4532           
=======================================
  Hits         4487     4487           
  Misses         45       45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syu-w syu-w force-pushed the CRAFT-2263-weekly-macos-tests branch 2 times, most recently from 75ee223 to 76ee0e8 Compare November 24, 2023 16:57
@mr-cal mr-cal self-requested a review November 27, 2023 16:09
@tigarmo tigarmo requested review from tigarmo and mr-cal and removed request for mr-cal November 27, 2023 16:09
mr-cal
mr-cal reviewed Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see the output of the CI job. Can you post a link and re-request a review from me?

.github/workflows/tests-weekly.yaml Show resolved Hide resolved
@syu-w syu-w force-pushed the CRAFT-2263-weekly-macos-tests branch 4 times, most recently from 8bb7d69 to 5f3a064 Compare November 28, 2023 16:02
@syu-w syu-w force-pushed the CRAFT-2263-weekly-macos-tests branch from 69d005d to 866b3c0 Compare November 29, 2023 17:22
@syu-w
Copy link
Contributor Author

syu-w commented Nov 29, 2023

I'd like to see the output of the CI job. Can you post a link and re-request a review from me?

Example: https://github.com/canonical/craft-providers/actions/runs/7022193869

@syu-w syu-w requested a review from mr-cal November 29, 2023 17:24
@mr-cal mr-cal mentioned this pull request Nov 29, 2023
Open
mr-cal
mr-cal approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I made a new issue (#467) to track the weekly CI failure.

@mr-cal mr-cal merged commit bc946f0 into main Nov 29, 2023
14 checks passed
@mr-cal mr-cal deleted the CRAFT-2263-weekly-macos-tests branch November 29, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@tigarmo tigarmo tigarmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syu-w @tigarmo @mr-cal