Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(snaps): inject base snap from host #444

Merged
merged 1 commit into from
Nov 10, 2023
Merged

feat(snaps): inject base snap from host #444

merged 1 commit into from
Nov 10, 2023

Conversation

syu-w
Copy link
Contributor

@syu-w syu-w commented Nov 7, 2023 •
edited
Loading

Also reuse the base when inject other snaps.

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

Merging #444 (fb693ef) into main (b885aea) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          57       57           
  Lines        4527     4532    +5     
=======================================
+ Hits         4482     4487    +5     
  Misses         45       45
Files Coverage Δ
craft_providers/actions/snap_installer.py 99.42% <100.00%> (+0.01%) ⬆️

@syu-w syu-w force-pushed the inject-more-snaps-from-host branch 2 times, most recently from f94ca4b to f333bf0 Compare November 8, 2023 08:11
@syu-w syu-w requested review from mr-cal and a team November 8, 2023 09:45
@syu-w syu-w changed the title feat(snaps): inject snaps from host if try to install same channel feat(snaps): inject base snap from host Nov 8, 2023
mr-cal
mr-cal requested changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I only have pedantic feedback.

craft_providers/base.py Outdated Show resolved Hide resolved
craft_providers/actions/snap_installer.py Outdated Show resolved Hide resolved
@syu-w syu-w force-pushed the inject-more-snaps-from-host branch 2 times, most recently from 3dd2c40 to 41416e8 Compare November 8, 2023 10:22
mr-cal
mr-cal approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks! Looks like the unit tests need a small fix.

@syu-w syu-w force-pushed the inject-more-snaps-from-host branch from 41416e8 to fb693ef Compare November 8, 2023 11:43
@sergiusens sergiusens merged commit 03704c1 into main Nov 10, 2023
@sergiusens sergiusens deleted the inject-more-snaps-from-host branch November 10, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@sergiusens sergiusens sergiusens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syu-w @sergiusens @mr-cal