Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grammar)!: generalized grammar type class #19

Merged
merged 7 commits into from
Apr 12, 2024
Merged

feat(grammar)!: generalized grammar type class #19

merged 7 commits into from
Apr 12, 2024

Conversation

syu-w
Copy link
Contributor

@syu-w syu-w commented Apr 9, 2024

No description provided.

@syu-w syu-w force-pushed the CRAFT-2699-generalized-model branch from fadbea4 to 21b6986 Compare April 9, 2024 19:02
@sergiusens sergiusens marked this pull request as ready for review April 10, 2024 16:12
@lengau lengau requested review from cmatsuoka and lengau April 11, 2024 16:20
cmatsuoka
cmatsuoka reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work quite nicely, I would just change the type name to Grammar instead of GrammarType.

craft_grammar/models.py Outdated Show resolved Hide resolved
craft_grammar/models.py Outdated Show resolved Hide resolved
cmatsuoka
cmatsuoka approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is a cool implementation that handles primitive types, if we extend this in the future to generic objects we can have something like Grammar[Part] which would extend grammar-awareness to basically everything in the parts definition.

@sergiusens sergiusens merged commit 01dedaa into main Apr 12, 2024
7 checks passed
@sergiusens sergiusens deleted the CRAFT-2699-generalized-model branch April 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@cmatsuoka cmatsuoka cmatsuoka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@syu-w @cmatsuoka @lengau @sergiusens