New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): add more grammar types #17

Merged

syu-w merged 2 commits into main from CRAFT-2656-more-types

Apr 5, 2024

Contributor

syu-w commented Mar 28, 2024 •

edited

Loading

Support bool, int, float, dict, and list of dict.

syu-w force-pushed the CRAFT-2656-more-types branch 13 times, most recently from aabbc45 to 2ac79f6 Compare

April 4, 2024 01:51

syu-w marked this pull request as ready for review

April 4, 2024 15:00


          feat(types): add more grammar types

1a98c0b

Support bool, int, float, dict, and list of dict.

syu-w force-pushed the CRAFT-2656-more-types branch from 2ac79f6 to 1a98c0b Compare

April 4, 2024 15:00

syu-w mentioned this pull request

feat(grammar): enable grammar-aware for all PartSpec canonical/craft-application#296

Merged

syu-w requested review from cmatsuoka and tigarmo

April 4, 2024 15:05

sergiusens requested review from mr-cal and removed request for cmatsuoka

April 4, 2024 15:41

mr-cal reviewed

View reviewed changes

Contributor

mr-cal left a comment

Code looks good - can you post a link to a PR or branch when you test integrating this with snapcraft?

craft_grammar/models.py Show resolved Hide resolved

tigarmo reviewed

View reviewed changes

craft_grammar/models.py Outdated Show resolved Hide resolved

tigarmo reviewed

View reviewed changes

Collaborator

tigarmo left a comment

I like the completess of the tests! Thanks

craft_grammar/models.py Show resolved Hide resolved

craft_grammar/models.py Outdated Show resolved Hide resolved

craft_grammar/models.py Outdated Show resolved Hide resolved

craft_grammar/models.py Outdated Show resolved Hide resolved


          fix: feedback

1253db5

mr-cal approved these changes

View reviewed changes

Contributor

mr-cal left a comment

Nice work.

The code here is fine and does what it is supposed to do, but I'm not sure if it makes sense to land this now or wait a little longer to implement Tiago's code-generated grammar class with generics.

tigarmo approved these changes

View reviewed changes

syu-w merged commit aacff29 into main

7 checks passed

syu-w deleted the CRAFT-2656-more-types branch

April 5, 2024 13:24

lengau referenced this pull request in canonical/charmcraft


          chore(deps): update internal packages (#1631)

c26661a

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| craft-application | `==2.1.0` -> `==2.4.0` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/craft-application/2.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/craft-application/2.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/craft-application/2.1.0/2.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/craft-application/2.1.0/2.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [craft-grammar](https://togithub.com/canonical/craft-grammar) |
`==1.1.2` -> `==1.2.0` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/craft-grammar/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/craft-grammar/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/craft-grammar/1.1.2/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/craft-grammar/1.1.2/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [craft-store](https://togithub.com/canonical/craft-store) | `==2.6.0`
-> `==2.6.1` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/craft-store/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/craft-store/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/craft-store/2.6.0/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/craft-store/2.6.0/2.6.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>canonical/craft-grammar (craft-grammar)</summary>

###
[`v1.2.0`](https://togithub.com/canonical/craft-grammar/releases/tag/1.2.0)

[Compare
Source](https://togithub.com/canonical/craft-grammar/compare/1.1.2...1.2.0)

##### What's Changed

- ci: use GH/JIRA integration bot by
[@&#8203;sergiusens](https://togithub.com/sergiusens) in
[https://github.com/canonical/craft-grammar/pull/15](https://togithub.com/canonical/craft-grammar/pull/15)
- style: make pyright less concerned about grammar methods by
[@&#8203;lengau](https://togithub.com/lengau) in
[https://github.com/canonical/craft-grammar/pull/16](https://togithub.com/canonical/craft-grammar/pull/16)
- feat(types): add more grammar types by
[@&#8203;syu-w](https://togithub.com/syu-w) in
[https://github.com/canonical/craft-grammar/pull/17](https://togithub.com/canonical/craft-grammar/pull/17)
- Release 1.2.0 by [@&#8203;cmatsuoka](https://togithub.com/cmatsuoka)
in
[https://github.com/canonical/craft-grammar/pull/18](https://togithub.com/canonical/craft-grammar/pull/18)

##### New Contributors

- [@&#8203;syu-w](https://togithub.com/syu-w) made their first
contribution in
[https://github.com/canonical/craft-grammar/pull/17](https://togithub.com/canonical/craft-grammar/pull/17)

**Full Changelog**:
canonical/craft-grammar@1.1.2...1.2.0

</details>

<details>
<summary>canonical/craft-store (craft-store)</summary>

###
[`v2.6.1`](https://togithub.com/canonical/craft-store/releases/tag/2.6.1)

[Compare
Source](https://togithub.com/canonical/craft-store/compare/2.6.0...2.6.1)

-   Remove dependency on `protobuf`
-   Explicitly note incompatibility with `keyring` v25.0

##### What's Changed

- chore(deps): update dependency setuptools to v69 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/canonical/craft-store/pull/154](https://togithub.com/canonical/craft-store/pull/154)
- build(deps): remove protobuf dep by
[@&#8203;lengau](https://togithub.com/lengau) in
[https://github.com/canonical/craft-store/pull/156](https://togithub.com/canonical/craft-store/pull/156)
- style(types): update pyright by
[@&#8203;lengau](https://togithub.com/lengau) in
[https://github.com/canonical/craft-store/pull/158](https://togithub.com/canonical/craft-store/pull/158)
- chore(deps): update dependency dev/coverage to v7.4.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/canonical/craft-store/pull/157](https://togithub.com/canonical/craft-store/pull/157)
- chore(deps): update dependency lint/ruff to v0.1.15 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/canonical/craft-store/pull/155](https://togithub.com/canonical/craft-store/pull/155)
- ci: use GH/JIRA integration bot by
[@&#8203;sergiusens](https://togithub.com/sergiusens) in
[https://github.com/canonical/craft-store/pull/161](https://togithub.com/canonical/craft-store/pull/161)
- fix: workaround for keyring 25 incompatibility by
[@&#8203;lengau](https://togithub.com/lengau) in
[https://github.com/canonical/craft-store/pull/163](https://togithub.com/canonical/craft-store/pull/163)
- chore(deps): update documentation dependencies by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/canonical/craft-store/pull/160](https://togithub.com/canonical/craft-store/pull/160)
- chore: release 2.6.1 by [@&#8203;lengau](https://togithub.com/lengau)
in
[https://github.com/canonical/craft-store/pull/164](https://togithub.com/canonical/craft-store/pull/164)

**Full Changelog**:
canonical/craft-store@2.6.0...2.6.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/canonical/charmcraft).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet