Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log message #14

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Fix log message #14

merged 2 commits into from
Feb 6, 2024

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Feb 6, 2024

This PR fixes a log message.
Before, we were using the abstract class directly, Rules.rule_type,

logger.debug("Reading %s rule from %s", Rules.rule_type, file_path)

which resulted in output such as:

Reading <property object at 0x7f1276e21590> rule from /var/lib/juju/agents/unit-prometheus-0/charm/src/prometheus_alert_rules/prometheus_tsdb_wal_truncations_failed.rule

Should use self.

@sed-i sed-i merged commit 83b7877 into main Feb 6, 2024
3 of 4 checks passed
@sed-i sed-i deleted the sed-i-patch-1 branch February 6, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant