Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #12

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Update CODEOWNERS #12

merged 3 commits into from
Jan 12, 2024

Conversation

mmkay
Copy link
Contributor

@mmkay mmkay commented Jan 4, 2024

No description provided.

@lucabello
Copy link
Contributor

Interesting that it fails unit tests; the inclusive naming thing is also weird, because the error I see is:

Error: Unable to resolve action. Repository not found: canonical-web-and-design/Inclusive-naming

The repo is reachable and public; also, the workflow is the same we use for our charm quality checks

@mmkay mmkay force-pushed the update-codeowners branch from 7647b5c to 0f1299e Compare January 11, 2024 12:24
@mmkay
Copy link
Contributor Author

mmkay commented Jan 11, 2024

@lucabello I fixed the unit tests - it looks like the error message in validation that was tested changed to contain file path. The inclusive naming check is, however, weirder. I see that there was a path change and inclusive naming seems to be now directly in canonical org but redirects work. I wonder if the issue isn't related to the repo we're in being private.

@simskij any ideas?

@mmkay mmkay merged commit d8d7f33 into main Jan 12, 2024
3 of 4 checks passed
@mmkay mmkay deleted the update-codeowners branch January 12, 2024 11:10
@simskij
Copy link
Member

simskij commented Jan 12, 2024

I can file a request with IS to make it internal if y'all think that might make a difference?

@mmkay
Copy link
Contributor Author

mmkay commented Jan 12, 2024

@simskij - although it certainly won't hurt, I think it might be better to fix the underlying redirect. On it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants