Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralized rules groups for libraries to import #117

Merged
merged 10 commits into from
Jan 22, 2025
Merged

Centralized rules groups for libraries to import #117

merged 10 commits into from
Jan 22, 2025

Conversation

MichaelThamm
Copy link
Contributor

@MichaelThamm MichaelThamm commented Jan 15, 2025 •
edited
Loading

This PR attempts to centralize the generic alert rule groups in cos-lib to remove code duplication. It is an extension of this merged PR:

Tandem PRs:

Note:

  • This will not break any CI since the generic rules existed in the Prometheus and Grafana agent libraries. Those will still exist there until the migration to these rules in cosl is complete.
  • This PR is not dependent on the status of the tandem PRs, rather they are dependent on this one!

@MichaelThamm MichaelThamm requested a review from a team as a code owner January 15, 2025 22:49
@MichaelThamm MichaelThamm marked this pull request as draft January 15, 2025 23:25
@lucabello lucabello mentioned this pull request Jan 16, 2025
Closed
@MichaelThamm MichaelThamm marked this pull request as ready for review January 17, 2025 20:17
sed-i
sed-i approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@sed-i sed-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Added some doc suggestions.

src/cosl/rules.py Show resolved Hide resolved
src/cosl/rules.py Show resolved Hide resolved
src/cosl/rules.py Show resolved Hide resolved
src/cosl/rules.py Show resolved Hide resolved
This was referenced Jan 21, 2025
Merged
Open
Open
@MichaelThamm MichaelThamm merged commit 602592c into main Jan 22, 2025
7 checks passed
@MichaelThamm MichaelThamm deleted the feature/central-alerts branch January 22, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sed-i sed-i sed-i approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelThamm @sed-i