Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean suspend time test (BugFix) #1702

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

fernando79513
Copy link
Collaborator

Description

We had several some tests with conflicting output files.
We have removed one unused test, and set coherent names for the attachment files.

Apart from the naming issues fixed in this PR, I think that all of these suspend tests could be simplified by:

  • Merge suspend_single.log and suspend_single_times.log. Since suspend_single_times.log already includes the contents of suspend_single.log, we could just have one log file that included all the information and check the part that we are interested in. It seems that we are already doing that in some suspend tests
  • Get rid of file checks inside the command:
    [ -e "$PLAINBOX_SESSION_SHARE"/suspend_single_times.log ] && sleep_time_check.py "$PLAINBOX_SESSION_SHARE"/suspend_single_times.log
    And just check if the file exists in the sleep_time_check.py script

We could tackle these in a follow-up PR or address them here if we consider that's the way to go.

Resolved issues

https://warthogs.atlassian.net/browse/CHECKBOX-1644

Documentation

Tests

@fernando79513 fernando79513 changed the title Clean suspend time test Clean suspend time test (BugFix) Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.01%. Comparing base (f31e3e9) to head (2e95292).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1702   +/-   ##
=======================================
  Coverage   49.01%   49.01%           
=======================================
  Files         372      372           
  Lines       40348    40348           
  Branches     6817     6817           
=======================================
  Hits        19777    19777           
  Misses      19849    19849           
  Partials      722      722           
Flag Coverage Δ
provider-base 24.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, we should really unify all those names

@fernando79513 fernando79513 merged commit 4b89d45 into main Jan 29, 2025
42 of 43 checks passed
@fernando79513 fernando79513 deleted the clean-suspend-time-test branch January 29, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants