Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had several some tests with conflicting output files.
We have removed one unused test, and set coherent names for the attachment files.
Apart from the naming issues fixed in this PR, I think that all of these suspend tests could be simplified by:
suspend_single.log
andsuspend_single_times.log
. Sincesuspend_single_times.log
already includes the contents ofsuspend_single.log
, we could just have one log file that included all the information and check the part that we are interested in. It seems that we are already doing that in some suspend tests[ -e "$PLAINBOX_SESSION_SHARE"/suspend_single_times.log ] && sleep_time_check.py "$PLAINBOX_SESSION_SHARE"/suspend_single_times.log
And just check if the file exists in the
sleep_time_check.py
scriptWe could tackle these in a follow-up PR or address them here if we consider that's the way to go.
Resolved issues
https://warthogs.atlassian.net/browse/CHECKBOX-1644
Documentation
Tests