Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LXD VM GPU passthrough test (New) #1690

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

pedro-avalos
Copy link
Collaborator

@pedro-avalos pedro-avalos commented Jan 21, 2025

Description

  • Add LXD VM physical GPU passthrough test to GPGPU provider
    • This is similar to the existing LXD container test, but it uses a virtual machine instead of a container

Resolved issues

Documentation

Tests

The test was already present (though misconfigured in the setup steps), so the unit tests are already present in Checkbox.

https://certification.canonical.com/submissions/status/301364

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.01%. Comparing base (9184e03) to head (c5f6285).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1690   +/-   ##
=======================================
  Coverage   49.01%   49.01%           
=======================================
  Files         372      372           
  Lines       40348    40348           
  Branches     6817     6817           
=======================================
  Hits        19777    19777           
  Misses      19849    19849           
  Partials      722      722           
Flag Coverage Δ
provider-gpgpu 90.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedro-avalos pedro-avalos force-pushed the CHECKBOX-1719-add-lxdvm-gpu-passthrough branch from dad4bba to 0f8f4d7 Compare January 22, 2025 13:36
@pedro-avalos pedro-avalos requested a review from Hook25 January 22, 2025 14:50
@pedro-avalos pedro-avalos marked this pull request as ready for review January 22, 2025 14:50
@pedro-avalos pedro-avalos force-pushed the CHECKBOX-1719-add-lxdvm-gpu-passthrough branch from 42c0bb7 to c5f6285 Compare January 22, 2025 15:23
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, the attached test log doesn't make it 100% clear this did actually pass, but we can do some cleanup afterwards I think. Good job

@Hook25 Hook25 merged commit f31e3e9 into main Jan 27, 2025
40 checks passed
@Hook25 Hook25 deleted the CHECKBOX-1719-add-lxdvm-gpu-passthrough branch January 27, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants