-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compare_resolution function (BugFix) #1683
base: main
Are you sure you want to change the base?
Conversation
There is no tkinter module in checkbox, hence, for snap you could add
|
e67e952
to
67b21d9
Compare
The current compare_resolution function uses deprecated functions, and it appears that any solution using Gdk with Wayland will fail to locate a primary monitor (https://gitlab.gnome.org/GNOME/gtk/-/issues/1028). Additionally, this change adds a hint if an error arises
67b21d9
to
7d62796
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
==========================================
- Coverage 48.99% 48.99% -0.01%
==========================================
Files 372 372
Lines 40321 40327 +6
Branches 6811 6811
==========================================
Hits 19757 19757
- Misses 19842 19848 +6
Partials 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
You may also need to add a unittest file for this |
submissions
@mckees Is the failed message as you expected? Since it looks like somehow it can still create a window, but the resolution is 0*0 |
Description
The current compare_resolution function uses deprecated functions, and it appears that any solution using Gdk with Wayland will fail to locate a primary monitor (https://gitlab.gnome.org/GNOME/gtk/-/issues/1028). Additionally, this change adds a hint if an error arises
Resolved issues
https://bugs.launchpad.net/kobuk/+bug/2083892
Documentation
Tests
I tested the function on its own locally, but @LiaoU3 will run further tests before merging